Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(GuildChannel): spread clone options to avoid infinite recursion #5800

Merged
merged 2 commits into from
Jun 10, 2021

Conversation

SpaceEEC
Copy link
Member

@SpaceEEC SpaceEEC commented Jun 10, 2021

Please describe the changes this PR makes and why it should be merged:

This PR resolves #5553 by spreading the clone options instead of using Util.mergeDefault.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

src/util/Util.js Outdated Show resolved Hide resolved
@SpaceEEC SpaceEEC changed the title fix(Util): add max depth for merge default fix(GuildChannel): spread clone options to avoid infinite recursion Jun 10, 2021
Copy link
Member

@kyranet kyranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can avoid the assignment, but LGTM.

@iCrawl iCrawl merged commit 2f5424b into discordjs:master Jun 10, 2021
@iCrawl iCrawl added this to the Version 13 milestone Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GuildChannel#clone exceeds maximum call stack when providing a CategoryChannel to the parent option
4 participants